Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mineclone2, mineclonia and mineclone5 support #55

Merged
merged 19 commits into from
Jan 15, 2024

Conversation

JamesClarke7283
Copy link
Contributor

This PR adds support for mineclone2 and related subgames.

It currently does not support the mg mod, but i will work to fix this.

_config.txt Outdated Show resolved Hide resolved
init.lua Outdated Show resolved Hide resolved
init.lua Outdated Show resolved Hide resolved
mod.conf Outdated Show resolved Hide resolved
init.lua Outdated Show resolved Hide resolved
@JamesClarke7283
Copy link
Contributor Author

It should be good to go now @Calinou

@Calinou
Copy link
Member

Calinou commented Jan 15, 2024

CI fails due to Luacheck errors:

Luacheck.................................................................Failed
- hook id: luacheck
- exit code: 1

Checking init.lua                                 4 warnings

    init.lua:36:7: value assigned to variable default_stone_sounds is unused
    init.lua:37:7: value assigned to variable default_metal_sounds is unused
    init.lua:40:24: accessing undefined variable mcl_sounds
    init.lua:41:24: accessing undefined variable mcl_sounds

Checking mg.lua                                   OK

Total: 4 warnings / 0 errors in 2 files

@JamesClarke7283
Copy link
Contributor Author

CI fails due to Luacheck errors:

Luacheck.................................................................Failed
- hook id: luacheck
- exit code: 1

Checking init.lua                                 4 warnings

    init.lua:36:7: value assigned to variable default_stone_sounds is unused
    init.lua:37:7: value assigned to variable default_metal_sounds is unused
    init.lua:40:24: accessing undefined variable mcl_sounds
    init.lua:41:24: accessing undefined variable mcl_sounds

Checking mg.lua                                   OK

Total: 4 warnings / 0 errors in 2 files

Fixed

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 4f7ec3b into minetest-mods:master Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants