A fix for Netherrack slab being called Deep Netherrack slab #63
Conversation
| @@ -78,6 +78,7 @@ Nether geode crystal. A crystalline structure with faint glow found inside large | |||
|
|
|||
| Netherrack= | |||
| Netherrack from deep in the mantle= | |||
| Netherrack Slab= | |||
There was a problem hiding this comment.
I think the s in slab should be lowercase, and in the .fr file as well.
(I don't know if the minetest.get_translator() file stuff is actually case sensitive, but probably easier to fix it than to test that)
|
I thought it was supposed to be capitalized, let me double check. |
|
I checked, and what I changed is in line with what was already there. i.e., all the other slabs are capitalized. Yes, I have two accounts. I keep accidentally switching. |
|
I can finish the French translation for you tomorrow, and maybe add a Spanish or something. |
nodes.lua
Outdated
| @@ -391,7 +391,7 @@ stairs.register_slab( -- register a slab without adding inner and outer stairs | |||
| "nether:rack", | |||
| {cracky = 2, level = 2}, | |||
| {"nether_rack.png"}, | |||
| S("Deep Netherrack slab"), | |||
| S("Netherrack slab"), | |||
There was a problem hiding this comment.
This S(...) function will search for the string "Netherrack slab" in the translation table, and then substitute it if it finds a localized version there. I made the suggestion because I didn't know whether that lookup operation is case-insensitive, this string with its lowercase s is why I suggested the keys in the translation files should also have a matching lowercase s.
Alternately you could leave the translation files alone and make this s uppercase.
Thanks for noticing and posting an issue+PR.
Several slabs and stairs were incorrectly named.
|
Ok, apparently a bunch of slabs and stairs had that issue. I think I fixed them all? So, this will make the translation work better. |
|
Nah, it wasn't about style preferences, it was about the strings in the .lua files needing to exactly match the strings in the translation files, so this latest change to just .lua strings makes more mismatches. I can fix it though (by running Facedeer's script), it's not a problem. |
|
Well, hopefully you are able to fix it. you lost me. |
|
Tell me if you want me to do the french |
|
Yup, make a new pull request |
|
Aight |
I noticed it was improperly named.