Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A fix for Netherrack slab being called Deep Netherrack slab #63

Merged
merged 4 commits into from Apr 15, 2023
Merged

A fix for Netherrack slab being called Deep Netherrack slab #63

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ce7b29
fix netherrack slab being called Deep Netherrack
JoeEnderman Apr 14, 2023
c288774
fix netherrack slab being called deep netherrack
JoeEnderman Apr 14, 2023
4b42e6a
fix netherrack slab being called deep netherack
JoeEnderman Apr 14, 2023
119b862
Fix several lowercase block names
JoeEnderman Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions locale/nether.fr.tr
View file
Open in desktop
Expand Up @@ -79,6 +79,7 @@ Nether geode crystal. A crystalline structure with faint glow found inside large

Netherrack=Roche du Nether
Netherrack from deep in the mantle=
Netherrack Slab=
Netherrack stair=
Nethersand=Sable du Nether
Outer Deep Nether Stair=
Expand Down
1 change: 1 addition & 0 deletions locale/template.txt
View file
Open in desktop
Expand Up @@ -78,6 +78,7 @@ Nether geode crystal. A crystalline structure with faint glow found inside large

Netherrack=
Netherrack from deep in the mantle=
Netherrack Slab=
Copy link
Collaborator

@Treer Treer Apr 14, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the s in slab should be lowercase, and in the .fr file as well.
(I don't know if the minetest.get_translator() file stuff is actually case sensitive, but probably easier to fix it than to test that)

Netherrack stair=
Nethersand=
Outer Deep Nether Stair=
Expand Down
2 changes: 1 addition & 1 deletion nodes.lua
View file
Open in desktop
Expand Up @@ -391,7 +391,7 @@ stairs.register_slab( -- register a slab without adding inner and outer stairs
"nether:rack",
{cracky = 2, level = 2},
{"nether_rack.png"},
S("Deep Netherrack slab"),
S("Netherrack slab"),
Copy link
Collaborator

@Treer Treer Apr 14, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This S(...) function will search for the string "Netherrack slab" in the translation table, and then substitute it if it finds a localized version there. I made the suggestion because I didn't know whether that lookup operation is case-insensitive, this string with its lowercase s is why I suggested the keys in the translation files should also have a matching lowercase s.

Alternately you could leave the translation files alone and make this s uppercase.

Thanks for noticing and posting an issue+PR.

minetest.registered_nodes["nether:rack"].sounds
)

Expand Down