Fix Inventory::moveItemSomewhere()

minetest · Sep 3, 2019 · 4582691 · 4582691
1 parent f3acdd3
commit 4582691
Showing 1 changed file with 5 additions and 19 deletions.
diff --git a/src/inventory.cpp b/src/inventory.cpp
@@ -717,27 +717,13 @@ void InventoryList::moveItemSomewhere(u32 i, InventoryList *dest, u32 count)
 	if (item1.empty())
 		return;
 
-	// Try to add the item to destination list
+	ItemStack leftover;
-	u32 dest_size = dest->getSize();
+	leftover = dest->addItem(item1);
-	// First try all the non-empty slots
-	for (u32 dest_i = 0; dest_i < dest_size; dest_i++) {
-		if (!m_items[dest_i].empty()) {
-			item1 = dest->addItem(dest_i, item1);
-			if (item1.empty()) return;
-		}
-	}
 
-	// Then try all the empty ones
+	if (!leftover.empty()) {
-	for (u32 dest_i = 0; dest_i < dest_size; dest_i++) {
+		// Add the remaining part back to the source item
-		if (m_items[dest_i].empty()) {
+		addItem(i, leftover);
-			item1 = dest->addItem(dest_i, item1);
-			if (item1.empty()) return;
-		}
 	}
-
-	// If we reach this, the item was not fully added
-	// Add the remaining part back to the source item
-	addItem(i, item1);
 }
 
 u32 InventoryList::moveItem(u32 i, InventoryList *dest, u32 dest_i,