Skip to content

Commit

Permalink
Bump minimum clang version to 7.0.1
Browse files Browse the repository at this point in the history
std::variant is broken in clang < 7.0.1 with libstdc++
see: llvm/llvm-project#32569
  • Loading branch information
Desour committed Sep 26, 2023
1 parent b0d5ced commit 591e456
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
Expand Up @@ -76,21 +76,21 @@ jobs:
./bin/minetest --run-unittests
# Older clang version (should be close to our minimum supported version)
clang_6_0:
clang_7:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- name: Install deps
run: |
source ./util/ci/common.sh
install_linux_deps clang-6.0 valgrind
install_linux_deps clang-7 valgrind
- name: Build
run: |
./util/ci/build.sh
env:
CC: clang-6.0
CXX: clang++-6.0
CC: clang-7
CXX: clang++-7

- name: Unittest
run: |
Expand Down
2 changes: 1 addition & 1 deletion doc/compiling/linux.md
Expand Up @@ -4,7 +4,7 @@

| Dependency | Version | Commentary |
| ---------- | ------- | ---------- |
| GCC | 7.5+ | or Clang 6.0+ |
| GCC | 7.5+ | or Clang 7.0.1+ |
| CMake | 3.5+ | |
| IrrlichtMt | - | Custom version of Irrlicht, see https://github.com/minetest/irrlicht |
| Freetype | 2.0+ | |
Expand Down

0 comments on commit 591e456

Please sign in to comment.