Skip to content

Commit

Permalink
Fix -Winconsistent-missing-override warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
Desour authored and grorp committed Sep 9, 2023
1 parent 2ad4c9e commit 7897450
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 26 deletions.
50 changes: 25 additions & 25 deletions src/client/content_cao.h
Expand Up @@ -144,23 +144,23 @@ class GenericCAO : public ClientActiveObject
return new GenericCAO(client, env);
}

inline ActiveObjectType getType() const
inline ActiveObjectType getType() const override
{
return ACTIVEOBJECT_TYPE_GENERIC;
}
inline const ItemGroupList &getGroups() const
{
return m_armor_groups;
}
void initialize(const std::string &data);
void initialize(const std::string &data) override;

void processInitData(const std::string &data);

bool getCollisionBox(aabb3f *toset) const;
bool getCollisionBox(aabb3f *toset) const override;

bool collideWithObjects() const;
bool collideWithObjects() const override;

virtual bool getSelectionBox(aabb3f *toset) const;
virtual bool getSelectionBox(aabb3f *toset) const override;

const v3f getPosition() const override final;

Expand All @@ -172,9 +172,9 @@ class GenericCAO : public ClientActiveObject

inline const ObjectProperties &getProperties() const { return m_prop; }

scene::ISceneNode *getSceneNode() const;
scene::ISceneNode *getSceneNode() const override;

scene::IAnimatedMeshSceneNode *getAnimatedMeshSceneNode() const;
scene::IAnimatedMeshSceneNode *getAnimatedMeshSceneNode() const override;

// m_matrixnode controls the position and rotation of the child node
// for all scene nodes, as a workaround for an Irrlicht problem with
Expand All @@ -201,7 +201,7 @@ class GenericCAO : public ClientActiveObject
return m_prop.stepheight;
}

inline bool isLocalPlayer() const
inline bool isLocalPlayer() const override
{
return m_is_local_player;
}
Expand All @@ -218,28 +218,28 @@ class GenericCAO : public ClientActiveObject

void setChildrenVisible(bool toset);
void setAttachment(int parent_id, const std::string &bone, v3f position,
v3f rotation, bool force_visible);
v3f rotation, bool force_visible) override;
void getAttachment(int *parent_id, std::string *bone, v3f *position,
v3f *rotation, bool *force_visible) const;
void clearChildAttachments();
void clearParentAttachment();
void addAttachmentChild(int child_id);
void removeAttachmentChild(int child_id);
ClientActiveObject *getParent() const;
const std::unordered_set<int> &getAttachmentChildIds() const
v3f *rotation, bool *force_visible) const override;
void clearChildAttachments() override;
void clearParentAttachment() override;
void addAttachmentChild(int child_id) override;
void removeAttachmentChild(int child_id) override;
ClientActiveObject *getParent() const override;
const std::unordered_set<int> &getAttachmentChildIds() const override
{ return m_attachment_child_ids; }
void updateAttachments();
void updateAttachments() override;

void removeFromScene(bool permanent);
void removeFromScene(bool permanent) override;

void addToScene(ITextureSource *tsrc, scene::ISceneManager *smgr);
void addToScene(ITextureSource *tsrc, scene::ISceneManager *smgr) override;

inline void expireVisuals()
{
m_visuals_expired = true;
}

void updateLight(u32 day_night_ratio);
void updateLight(u32 day_night_ratio) override;

void setNodeLight(const video::SColor &light);

Expand All @@ -254,7 +254,7 @@ class GenericCAO : public ClientActiveObject

void updateNodePos();

void step(float dtime, ClientEnvironment *env);
void step(float dtime, ClientEnvironment *env) override;

void updateTexturePos();

Expand All @@ -268,14 +268,14 @@ class GenericCAO : public ClientActiveObject

void updateBonePosition();

void processMessage(const std::string &data);
void processMessage(const std::string &data) override;

bool directReportPunch(v3f dir, const ItemStack *punchitem=NULL,
float time_from_last_punch=1000000);
float time_from_last_punch=1000000) override;

std::string debugInfoText();
std::string debugInfoText() override;

std::string infoText()
std::string infoText() override
{
return m_prop.infotext;
}
Expand Down
2 changes: 1 addition & 1 deletion src/client/game.cpp
Expand Up @@ -578,7 +578,7 @@ class GameGlobalShaderConstantSetter : public IShaderConstantSetter
m_saturation_pixel.set(&saturation, services);
}

void onSetMaterial(const video::SMaterial &material)
void onSetMaterial(const video::SMaterial &material) override
{
video::ITexture *texture = material.getTexture(0);
if (texture) {
Expand Down

0 comments on commit 7897450

Please sign in to comment.