Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Write common mapgen params to map_meta.txt on world initialization
- Loading branch information
Showing
2 changed files
with
34 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad690c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are only a few chosen parameters written? You miss things like
mgv6_freq_beach
andmg_biome_np_heat
. Also, any new parameters have to be added in two places now. You should usewriteParamsToSettings
or similar.ad690c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to include a ton of additional dependencies.
Not having these parameters written doesn't matter much until you're able to edit those settings from within the user interface. Mapgen-specific parameters are a bit too out-of-scope here IMO