Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto build client appimage #10561

Merged
merged 4 commits into from Nov 15, 2020
Merged

Conversation

Lejo1
Copy link
Contributor

@Lejo1 Lejo1 commented Oct 26, 2020

Appimages are easy to use cross compatible files including everything to run the application.
This PR adds an automated build to create a client appimage using appimagebuilder to the gitlab ci

Such appimages are portable and don't require any additional installations.

Thanks to @An0n3m0us and @Calinou for the helping me out!

PR also removes the old ubuntu:14-04 build with the new ubuntu:18-04 build

To do

This PR is ready to review. Might need some library changes for OS support

  • Test on different linux distributions (Done: Ubuntu, Debian)
  • Resolve the Problem in the Desktop file (The builder complains about PrefersNonDefaultGPU=true)
  • Clean library list

How to test

I created a gitlab Ci for my minetest fork.
Download Appimage

@Calinou Calinou added Feature ✨ PRs that add or enhance a feature Linux labels Oct 26, 2020
@Calinou
Copy link
Member

Calinou commented Oct 26, 2020

Resolve the Problem in the Desktop file (The builder complains about PrefersNonDefaultGPU=true)

You can remove PrefersNonDefaultGPU=true from the desktop file using sed when building.

@paramat paramat added the @ Build CMake, build scripts, official builds, compiler and linker errors label Oct 26, 2020
.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
AppImageBuilder.yml Outdated Show resolved Hide resolved
AppImageBuilder.yml Outdated Show resolved Hide resolved
@Lejo1
Copy link
Contributor Author

Lejo1 commented Oct 27, 2020

You can remove PrefersNonDefaultGPU=true from the desktop file using sed when building.

Thanks, Good Idea! Did that.

@Lejo1 Lejo1 marked this pull request as ready for review October 27, 2020 13:38
@An0n3m0us
Copy link
Contributor

An0n3m0us commented Oct 31, 2020

Ubuntu 16.04: libunistring.so.2: cannot open shared object file: No such file or directory
After adding that library, the game works as expected.

I would fix it myself if I knew how these automated builds work xD

Works on a clean installation of Arch Linux (Manjaro Linux 20.1.2).

@Lejo1
Copy link
Contributor Author

Lejo1 commented Nov 1, 2020

Thanks for the feedback!
I excluded some random libraries cause I thought they weren't needed (also libunistring).
Should work now (When build is done and I changed the link)

AppImageBuilder.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure, why not. LGTM.

@SmallJoker SmallJoker merged commit a16e412 into minetest:master Nov 15, 2020
@Lejo1 Lejo1 deleted the gitlab_appimage-builder branch November 30, 2020 18:05
HybridDog pushed a commit to HybridDog/minetest that referenced this pull request Dec 17, 2020
* Replace ubuntu:14.04 with ubuntu 18:04
* Auto build client appimage

Co-authored-by: sfan5 <sfan5@live.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors Feature ✨ PRs that add or enhance a feature Linux >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants