Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show mod.conf warnings for enabled mods #11037

Closed
rubenwardy opened this issue Mar 7, 2021 · 4 comments
Closed

Only show mod.conf warnings for enabled mods #11037

rubenwardy opened this issue Mar 7, 2021 · 4 comments
Labels
Concept approved Approved by a core dev: PRs welcomed! Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature

Comments

@rubenwardy
Copy link
Member

rubenwardy commented Mar 7, 2021 •
edited
Loading

Shouldn't such warnings only be shown for mods that are activated for the world?

I get 720 lines on stderr just by starting a singleplayer game and closing immediately afterwards. And I don't want to maintain all the old mods that I have lying around.
(I've set the deprecation handling mode to none now. :/)

Originally posted by @Desour in #10753 (comment)
@rubenwardy
Copy link
Member Author

Also: it might be worth removing the name warning, as it's less useful with ContentDB. And an officially linked tool to update mod.conf from depends.txt and description would be nice

@sfan5
Copy link
Member

sfan5 commented Mar 7, 2021

Shouldn't such warnings only be shown for mods that are activated for the world?

Yes please

@SmallJoker SmallJoker added Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature Concept approved Approved by a core dev: PRs welcomed! labels Mar 8, 2021
@wsor4035
Copy link
Contributor

Also: it might be worth removing the name warning, as it's less useful with ContentDB. And an officially linked tool to update mod.conf from depends.txt and description would be nice

https://github.com/wsor4035/mt_convert

@rubenwardy
Copy link
Member Author

was implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Concept approved Approved by a core dev: PRs welcomed! Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sfan5 @SmallJoker @rubenwardy @wsor4035