Fix access violation in create_schematic() #11534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11533, schematics saved from y locations higher than 0 would cause an access violation if layer probabilities were specified
See #11533 for more details
To do
This PR is Ready for Review.
How to test
/nocrashy
chat command for the mod to save a schematic without crashing, and/crashy
for it to cause an access violation.l_create_schematic()
sanitizes theypos
it receives from lua before using it as an index. (I didn't notice any, but also don't know what the policy is)