Clean up/improve some scriptapi error handling code #11594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
commented
Sep 5, 2021
| runCallbacks(1, RUN_CALLBACKS_MODE_OR_SC); | ||
| } catch (LuaError &e) { | ||
| getClient()->setFatalError(e); | ||
| } |
There was a problem hiding this comment.
The client needs this because it does not have a central place to catch LuaErrors
sfan5
commented
Sep 5, 2021
SmallJoker
reviewed
Sep 10, 2021
sfan5
force-pushed
the
cppapicleanup
branch
from
6016748
to
b935f93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly cleanup, one specific improvement for
s_item.cpp: If the return type was wrong the error message did not contain the callback that was called (leaving server admins guessing).To do
This PR is Ready for Review.