Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket-related cleanups #11903

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Socket-related cleanups #11903

merged 2 commits into from
Dec 29, 2021

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Dec 29, 2021

This doesn't fix any bug but the error messages are now actually correct (on Windows).

To do

This PR is Ready for Review.

SmallJoker
SmallJoker approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<sfan5> msvc and tested in a vm

LGTM.
Tested on Ubuntu. No issues found.

@sfan5 sfan5 merged commit 0ea8df4 into minetest:master Dec 29, 2021
@sfan5 sfan5 deleted the socketfix branch December 29, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug Code quality One approval ✅ ◻️ Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfan5 @SmallJoker