Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy OpenGL preference mismatch between Minetest and IrrlichtMt #12041

Closed
JosiahWI opened this issue Feb 2, 2022 · 1 comment
Closed

Legacy OpenGL preference mismatch between Minetest and IrrlichtMt #12041

JosiahWI opened this issue Feb 2, 2022 · 1 comment
Labels
Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible

Comments

@JosiahWI
Copy link
Contributor

JosiahWI commented Feb 2, 2022

Minetest version
544b9d5
IrrlichtMt version
2fec5e5
OS / Hardware

Operating system: N/A
CPU: N/A

GPU model: N/A
OpenGL version: N/A

Summary

Minetest has a cache variable OPENGL_GL_PREFERENCE that determines whether Legacy OpenGL is preferred or not, but IrrlichtMt always prefers Legacy OpenGL regardless of Minetest's cache variable. Since IrrlichtMt always wants the Legacy version anyway, my suggested fix is to remove the cache option and let IrrlichtMt handle the OpenGL requirements entirely. The comments could be preserved by moving them to IrrlichtMt, or by requesting the Legacy version (no effect; for style only) with the appropriate comments before find_package(IrrlichtMt).

@JosiahWI JosiahWI added the Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible label Feb 2, 2022
@rubenwardy
Copy link
Member

That variable was set to silence a CMake warning

sfan5 added a commit to sfan5/minetest that referenced this issue Feb 26, 2022
IrrlichtMt now provides this for us (see last commit)
fixes minetest#12041
@sfan5 sfan5 closed this as completed in ad7c72c Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible
Projects
None yet
Development

No branches or pull requests

2 participants