Alternative I: Reduce active mgmt interval for a bit when a player joins #12925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, I also implemented the alternative: Pass a flag to map->getBlockOrEmerge(...) and pass that through to the emerge thread(s), and then activate the blocks as soon as it is emerged. I have not observed that to be better (but I also haven't tested that with many users.) If folks are interested I can post that as alternate PR. NM: See #12927 |
Zughy
added
Bugfix 🐛
lhofhansl
changed the title
lhofhansl
removed
the
Discussion
lhofhansl
changed the title
sfan5
approved these changes
Nov 10, 2022
sfan5
changed the title
|
I agree that this more "organic" than the other option. It will also deal well with a slow server my trying a few time with larger wait times in between. |
appgurueu
pushed a commit
to appgurueu/minetest
that referenced
this pull request
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #12927
Fixes #10884
When a player joins, active blocks take a bit to be emerged and activated, which means entities stored there take some time to appear.
When the player has been attached to (say) a flying entity they will now fall to their deatch.
Is this a quick fix. A full fix would enqueue these blocks immediately and then activate them upon emerge.
Downside: The server does more work for a short time when the effective mgmt interval is shortened for everyone.
How to test
Attach yourself to a flying entity. Try the
balloon,blimp or similar mods. Leave and rejoin. You should be re-attached immediately.