Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize hotbar immediately before drawing #12930

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Resize hotbar immediately before drawing #12930

merged 2 commits into from
Nov 9, 2022

Conversation

x2048
Copy link
Contributor

@x2048 x2048 commented Nov 4, 2022

Avoids incorrect rendering when hotbar uses outdated screen dimensions

Fixes #12852.

To do

This PR is Ready for Review.

How to test

  1. Set fps = 2
  2. Start the game (assuming you have at least one node item in the inventory)
    • NO fullscreen inventory item should be rendered in the first frame.
  3. Press ESC
  4. Resize the window quickly (maximize/restore)
    • no fullscreen inventory item should be rendered in any frame.

@x2048
Resize hotbar immediately before drawing
31f9747 
Avoids incorrect rendering when hotbar uses outdated screen dimensions
@x2048 x2048 added @ Client / Audiovisuals Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Bugfix 🐛 PRs that fix a bug labels Nov 4, 2022
@x2048 x2048 added this to the 5.7.0 milestone Nov 4, 2022
@x2048 x2048 requested a review from lhofhansl November 4, 2022 20:09
@x2048 x2048 self-assigned this Nov 4, 2022
nerzhul
nerzhul reviewed Nov 5, 2022
View reviewed changes
src/client/render/plain.cpp Outdated Show resolved Hide resolved
@TurkeyMcMac TurkeyMcMac merged commit 81bfc9c into minetest:master Nov 9, 2022
appgurueu pushed a commit to appgurueu/minetest that referenced this pull request May 2, 2023
@x2048 @appgurueu
Resize hotbar immediately before drawing (minetest#12930)
ac5f14d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerzhul nerzhul nerzhul left review comments

@sfan5 sfan5 sfan5 approved these changes

@lhofhansl lhofhansl Awaiting requested review from lhofhansl

Assignees

@x2048 x2048

Labels
Bugfix 🐛 PRs that fix a bug @ Client / Audiovisuals One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

Held items jumpscare on world startup
4 participants
@x2048 @nerzhul @sfan5 @TurkeyMcMac