New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NOSQUASH] Use cpp17, and some cleanups #13587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desour
added
the
Maintenance
Tasks to keep the codebase and related parts in order, including architectural improvements
label
Jun 12, 2023
lhofhansl
reviewed
Jun 13, 2023
lhofhansl
reviewed
Jun 14, 2023
Nice. Looks good. The one extra break looks weird, unless that was a (glaring) bug before. |
sfan5
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
numberZero
reviewed
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Maintenance
Tasks to keep the codebase and related parts in order, including architectural improvements
>= Two approvals ✅ ✅
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions for each commit:
try_lock
is called without using the return value. (Found because of[[nodiscard]]
.)Note: The Thread logic still looks faulty to me, i.e. I'm not sure if there's a race condition if the
try_lock
fails, or if we sometimes calltry_lock
on a mutex locked by the current thread (which is UB). Someone should fix or explain this at some point.Optional
type is replaced withstd::optional
.namespace foo { namespace bar { ... }}
are replaced by the new syntaxnamespace foo::bar { ... }
.STATIC_ASSERT
macro is replaced bystatic_assert
. (This is not C++17 specific, and could've been done much earlier.)-Wimplicit-fallthrough
warnings are no longer disabled. The[[fallthrough]]
attribute is now guaranteed to exist. (Btw. we can easily use attributes of newer C++ standards, see also feature testing.)(Note: The same could be done for the unused-parameter warnings, with
[[maybe_unused]]
. But there seem to be many irrlicht functions triggering the warning, and it doesn't seem worth it.)[[noreturn]]
is used, as opposed to the compiler-specific syntax. (Also not new in C++17.)(Related: #13583)
Related (no dependency, but you'll get deprecation warnings without): minetest/irrlicht#202
To do
This PR is a Ready for Review.
How to test
Build.