New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding gettext in the compilation dependency packages list #13602
Conversation
Note: I have set the version for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The concept is good. We discussed about this on Discord before this PR. There are some changes needed, though.
Note that the commit messages don't explain what changes were made. Maybe that can be adjusted during squash so that the git log doesn't show the most recent commit as "Initial commit". |
Oh. I had done the initial commit first on my fork of the repo. That does make it confusing in the light of this PR 😅 |
Have I addressed all of them is anything pending? |
I commented about a small problem for |
Ah, I missed the two bottom rows 👌 |
I am labelling this PR as Trivial since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me.
:D |
I have added the gettext package in the table showing the dependencies and in the command specific to the distros/OSes, as per my research, which could possibly have issues.