Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gettext in the compilation dependency packages list #13602

Merged
merged 7 commits into from Jun 24, 2023

Conversation

src4026
Copy link
Contributor

@src4026 src4026 commented Jun 17, 2023

I have added the gettext package in the table showing the dependencies and in the command specific to the distros/OSes, as per my research, which could possibly have issues.

@src4026 src4026 changed the title Adding gettext as in the compilation dependcy packages list Adding gettext in the compilation dependcy packages list Jun 17, 2023
@src4026 src4026 changed the title Adding gettext in the compilation dependcy packages list Adding gettext in the compilation dependency packages list Jun 17, 2023
@src4026
Copy link
Contributor Author

src4026 commented Jun 17, 2023

Note: I have set the version for gettext in the table as 0.21+. The latest version is 0.22, but most platforms have 0.21 as the present version.

Copy link
Member

@srifqi srifqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concept is good. We discussed about this on Discord before this PR. There are some changes needed, though.

doc/compiling/linux.md Show resolved Hide resolved
doc/compiling/windows.md Show resolved Hide resolved
doc/compiling/linux.md Outdated Show resolved Hide resolved
@JosiahWI
Copy link
Contributor

Note that the commit messages don't explain what changes were made. Maybe that can be adjusted during squash so that the git log doesn't show the most recent commit as "Initial commit".

@src4026
Copy link
Contributor Author

src4026 commented Jun 18, 2023

Note that the commit messages don't explain what changes were made. Maybe that can be adjusted during squash so that the git log doesn't show the most recent commit as "Initial commit".

Oh. I had done the initial commit first on my fork of the repo. That does make it confusing in the light of this PR 😅

@src4026
Copy link
Contributor Author

src4026 commented Jun 22, 2023

The concept is good. We discussed about this on Discord before this PR. There are some changes needed, though.

Have I addressed all of them is anything pending?

@srifqi
Copy link
Member

srifqi commented Jun 23, 2023

I commented about a small problem for doc/compiling/linux.md above.

@src4026
Copy link
Contributor Author

src4026 commented Jun 23, 2023

I commented about a small problem for doc/compiling/linux.md above.

Ah, I missed the two bottom rows 👌

@srifqi
Copy link
Member

srifqi commented Jun 24, 2023

I am labelling this PR as Trivial since gettext is already used in all CI workflows.

@srifqi srifqi added the Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines label Jun 24, 2023
Copy link
Member

@srifqi srifqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me.

doc/compiling/windows.md Outdated Show resolved Hide resolved
@sfan5 sfan5 merged commit 4fb6754 into minetest:master Jun 24, 2023
@src4026
Copy link
Contributor Author

src4026 commented Jun 25, 2023

:D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Documentation One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants