Settings GUI: Move shadows dropdown to Shaders, remove Most Used #13713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13476
The aim of the new settings GUI is to make it much easier for users to find and change settings based on a logical categorisation of settings. Most Used was only intended to be temporary, after this PR and #13704 it's no longer needed
The shadows dropdown is now on the Shaders page. The dropdown index is no longer persisted, it's instead detected based on the actual settings. Changing shadow settings manually shows "Custom" on the dropdown.
Note that I intend to hide the dynamic shadow settings (except this dropdown) as advanced, I've kept the settings as-is so that it's easier to test the behaviour of the dropdown - especially "Custom".
To do
This PR is Ready for Review
How to test