Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings GUI: Move shadows dropdown to Shaders, remove Most Used #13713

Merged

Conversation

rubenwardy
Copy link
Member

@rubenwardy rubenwardy commented Aug 2, 2023

Part of #13476

The aim of the new settings GUI is to make it much easier for users to find and change settings based on a logical categorisation of settings. Most Used was only intended to be temporary, after this PR and #13704 it's no longer needed

The shadows dropdown is now on the Shaders page. The dropdown index is no longer persisted, it's instead detected based on the actual settings. Changing shadow settings manually shows "Custom" on the dropdown.

Note that I intend to hide the dynamic shadow settings (except this dropdown) as advanced, I've kept the settings as-is so that it's easier to test the behaviour of the dropdown - especially "Custom".

image

To do

This PR is Ready for Review

How to test

  • Clear your minetest.conf
  • Open settings GUI, go to Shaders
  • Check the dynamic shadows check box, see that the drop says Medium
  • Set dynamic shadows to a preset, see the values below change
  • Change a value below, see the drop down set to "Custom"
  • Set a preset, see the values change again. Check that custom is not available in the drop down

The aim of the new settings GUI is to make it much easier
for users to find and change settings based on a logical
categorisation of settings. Most Used goes against this
goal.

Part of minetest#13476
@rubenwardy rubenwardy added Feature ✨ PRs that add or enhance a feature @ Mainmenu @ Content / PkgMgr @ Startup / Config / Util Roadmap The change matches an item on the current roadmap. Formspec UI/UX and removed @ Content / PkgMgr labels Aug 2, 2023
@rubenwardy rubenwardy requested a review from x2048 August 2, 2023 17:59
@rubenwardy rubenwardy changed the title Settings: Move shadows dropdown to Shaders, remove Most Used Settings GUI: Move shadows dropdown to Shaders, remove Most Used Aug 2, 2023
@rubenwardy rubenwardy mentioned this pull request Aug 2, 2023
17 tasks
@rubenwardy rubenwardy added this to the 5.8.0 milestone Aug 2, 2023
@lhofhansl
Copy link
Contributor

Works for me.

(If now we can get rid of the "Open Settings" button somehow...)

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed a few settings back and forth. The "Shadows" options do work well. Whereas I think that the "Most used" tab would still be useful, it is hopefully soon superseded by the further rework tasks you already announced.

@rubenwardy
Copy link
Member Author

Was hoping #13704 would get merged before this one. I suppose it doesn't matter as long as it's merged before release

@rubenwardy rubenwardy merged commit 752ce1a into minetest:master Aug 5, 2023
15 checks passed
@rubenwardy rubenwardy deleted the new_settings_remove_most_used branch August 5, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature ✨ PRs that add or enhance a feature Formspec @ Mainmenu Roadmap The change matches an item on the current roadmap. @ Startup / Config / Util >= Two approvals ✅ ✅ UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants