Don't trigger a key event if a key with the same associated char was pressed #13773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grorp
approved these changes
Sep 2, 2023
There was a problem hiding this comment.
Confirmed the bug on Linux with non-SDL Irrlicht. The fix works and makes sense.
The fix also results in being unable to change your viewing range using the numpad + and - keys with the default keymap, but I don't think that's a problem (this is expected, the non-numpad versions of the keys still work).
I can't reproduce the bug on Linux with SDL Irrlicht. If you press a numpad key there, Char always seems to be set to 0.
|
Consider adding a short unit test for |
sfan5
added
the
Action / change needed
Done |
savilli
commented
Sep 13, 2023
| @@ -111,7 +111,7 @@ void TestKeycode::testCompare() | |||
| { | |||
| // Basic comparison | |||
| UASSERT(KeyPress("5") == KeyPress("KEY_KEY_5")); | |||
| UASSERT(!(KeyPress("5") == KeyPress("KEY_NUMPAD_5"))); | |||
| UASSERT(!(KeyPress("5") == KeyPress("KEY_NUMPAD5"))); | |||
There was a problem hiding this comment.
This was broken for a while
grorp
removed
the
Action / change needed
erlehmann
added a commit
to erlehmann/minetest
that referenced
this pull request
Oct 29, 2023
…har was pressed (minetest#13773)" This reverts commit d57c936. The reverted commit prevented recognition of key combinations. Several keyboard layouts use a key combination to input a “+” (e.g. Neo2); therefore some users could no longer input “+” to increase the view range.
erlehmann
added a commit
to erlehmann/minetest
that referenced
this pull request
Oct 29, 2023
…har was pressed (minetest#13773)" This partially reverts commit d57c936. The reverted commit prevented recognition of key combinations. It correctly changed a test case to no longer use “KEY_NUMPAD_5”. Several keyboard layouts use a key combination to input a “+” (e.g. Neo2); therefore some users could no longer input “+” to increase the view range. Co-authored-by: savilli <78875209+savilli@users.noreply.github.com>
sfan5
pushed a commit
that referenced
this pull request
Oct 30, 2023
…har was pressed (#13773)" This partially reverts commit d57c936. The reverted commit prevented recognition of key combinations. It correctly changed a test case to no longer use “KEY_NUMPAD_5”. Several keyboard layouts use a key combination to input a “+” (e.g. Neo2); therefore some users could no longer input “+” to increase the view range. Co-authored-by: savilli <78875209+savilli@users.noreply.github.com>
cx384
pushed a commit
to cx384/minetest
that referenced
this pull request
Dec 9, 2023
…har was pressed (minetest#13773)" This partially reverts commit d57c936. The reverted commit prevented recognition of key combinations. It correctly changed a test case to no longer use “KEY_NUMPAD_5”. Several keyboard layouts use a key combination to input a “+” (e.g. Neo2); therefore some users could no longer input “+” to increase the view range. Co-authored-by: savilli <78875209+savilli@users.noreply.github.com>
kawogi
pushed a commit
to kawogi/minetest
that referenced
this pull request
Dec 19, 2023
kawogi
pushed a commit
to kawogi/minetest
that referenced
this pull request
Dec 19, 2023
…har was pressed (minetest#13773)" This partially reverts commit d57c936. The reverted commit prevented recognition of key combinations. It correctly changed a test case to no longer use “KEY_NUMPAD_5”. Several keyboard layouts use a key combination to input a “+” (e.g. Neo2); therefore some users could no longer input “+” to increase the view range. Co-authored-by: savilli <78875209+savilli@users.noreply.github.com>
cosin15
pushed a commit
to cosin15/minetest
that referenced
this pull request
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13770
See #13770 (comment)
To do
This PR is Ready for Review.
How to test
Check that pressing a numpad key doesn't change the active item