Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide server address from pause menu #13853

Closed
copygirl opened this issue Sep 28, 2023 · 6 comments · Fixed by #14082
Closed

Add option to hide server address from pause menu #13853

copygirl opened this issue Sep 28, 2023 · 6 comments · Fixed by #14082
Labels
@ Builtin Feature request Issues that request the addition or enhancement of a feature @ Startup / Config / Util UI/UX

Comments

@copygirl
Copy link

copygirl commented Sep 28, 2023

Problem

When streaming Minetest, I wish to not expose the server address to the public. However, the pause menu simply shows the connection info in the "Game Info" section, and this appears to be hardcoded in the source code.

Now, I'm nowhere near big enough to be worried about getting griefed, or my server owner DDoS'd, but it's just bad form to expose this information. Besides, there could always be a bigger fish who wants to play this game, but may be discouraged knowing that opening the pause / escape menu could leak sensitive information.

I'm frustrated whenever I see a game that exposes connection info, and this is a pretty bad case of that. I do have to say, as a FOSS-advocate I'm a little embarrassed. Minetest has been around for such a long time and this issue hasn't been addressed or even talked about, at least as far as I could see. Minecraft too had this issue in its infancy, but it was fixed relatively early in its development.

Additionally, the next step would be to overhaul the "Join Game" tab in the main menu, but that looks like a lot more work compared to what I'm trying to ask for here, so that should definitely get its own dedicated issue.

Solutions

  • Add an option to the settings to hide connection info in pause menu.
  • (optional) Hide the connection info by default.
  • (optional) Add a button to un-hide the connection info temporarily until the pause-menu is closed again.

Alternatives

  • Never click escape?
  • Set up a proxy. (Not user-friendly.)
  • Remove the information entirely. (suggested by @rubenwardy)
@copygirl copygirl added the Feature request Issues that request the addition or enhancement of a feature label Sep 28, 2023
@rubenwardy
Copy link
Member

Probably worth just removing this information from the pause menu

@NathanSalapat
Copy link
Contributor

Isn't this information already public just by looking at the server list? You don't even need minetest to view the server list.

@rubenwardy
Copy link
Member

Private servers aren't on the server list, but will have the address shown in the pause menu

@copygirl
Copy link
Author

copygirl commented Sep 28, 2023

@NathanSalapat Non-public servers don't show up on the server list.

If a streamer plays multiplayer, they might want to avoid accidentally revealing the connection information of the server they're playing on to the public. Avoiding showing the connection screen on stream can be done relatively easily by switching to a different scene (which doesn't show the game) while connecting, or using a shortcut to start Minetest with arguments to connect to the server directly. But while playing it is difficult to avoid switching to the pause menu, say if you want to focus another window. I would like to avoid this leaking the server address.

@NathanSalapat
Copy link
Contributor

You're right, I hadn't thought of that specific instance.

@fluxionary
Copy link
Contributor

@copygirl in the meantime, if you want to hide the address, you can create a custom entry in your hosts file (search "how to edit host file") that's only meaningful on your computer and not anywhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Builtin Feature request Issues that request the addition or enhancement of a feature @ Startup / Config / Util UI/UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants