Change some keys to be triggered once every key press

[srifqi]

Goal of the PR
This PR tries to make some keys to be triggered once every key press (using wasKeyPressed()).
Those keys are listed below:

• KeyType::CAMERA_MODE
• KeyType::SCREENSHOT
• KeyType::TOGGLE_BLOCK_BOUNDS
• KeyType::TOGGLE_HUD
• KeyType::MINIMAP
• KeyType::TOGGLE_CHAT
• KeyType::TOGGLE_FOG
• KeyType::TOGGLE_DEBUG
• KeyType::TOGGLE_PROFILER
• KeyType::RANGESELECT

How does the PR work?
This PR changes the key detection from wasKeyDown() to wasKeyPressed() for the keys listed above. The list contains keys that might cause sudden graphical changes (or creating new image files for KeyType::SCREENSHOT) when being pressed down continuously.

Does it resolve any reported issue?
Yes, this PR tries to fix #13868 (and also some of #11900).

Does this relate to a goal in the roadmap?
Yes, this PR tries to create a better UI/UX.

To do

This PR is Ready for Review.

How to test

1. Play in a Minetest world.
2. Press down (and hold) the toggle camera mode key.
3. The action is triggered once.
4. Release the key.
5. Repeat step 2–4 with the rest: take screenshot, toggle block bounds, toggle HUD, toggle minimap, toggle chat, toggle fog, toggle debug, toggle profiler, and toggle (maximum) range select.

[ghost]

Darn, I liked holding down the camera button and watching the headache mode video 🤣.

[grorp]

I agree that "no flashing" is an improvement, but the delay introduced by triggering on release instead of on press feels weird for me. If we do this, I suggest doing it for all "toggles" to make it more consistent and thus easier to get used to.

A different solution that wouldn't introduce a delay would be ignoring repeated press events, i.e. ignoring all press events except the first one until the next release event.

[srifqi]

I suggest doing it for all "toggles" to make it more consistent and thus easier to get used to.

I was going to do that, but I do not have enough reasons. That might be a good reason to do it because your alternative solution is harder (at least for me) to implement.

[grorp]

I just found out that my alternative solution is trivial to implement: Just replace wasKeyDown with wasKeyPressed. I suggest doing this, then it also isn't as important anymore to do it for all keys.

More keys where using wasKeyPressed would be good:

• SCREENSHOT
• TOGGLE_BLOCK_BOUNDS
• TOGGLE_CHAT
• TOGGLE_DEBUG
• TOGGLE_PROFILER

[srifqi]

Thank you! TIL about how wasKeyPressed() works (a little). I changed it to wasKeyPressed() and added more keys from your list.

[grorp]

Looks good to me, let's see what users think about this (will they notice?). We can always do this for more keys later, but the ones changed by this PR are the most annoying ones.

[SmallJoker]

Unlike the function name may indicate, the action is triggered right after pressing down the key. No delay, no objections. Works on my machine.