Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text containers wider in the Volume Change dialog #13995

Merged
merged 1 commit into from Nov 15, 2023

Conversation

srifqi
Copy link
Member

@srifqi srifqi commented Nov 14, 2023

Goal of the PR
This PR tries to make some texts' container in the Volume Change dialog wider to account for translations.

How does the PR work?
This PR changes dimensions of some GUI elements in the Volume Change dialog:

Element Before After
Sound Volume: 50% text 160 × 20 300 × 20
Muted checkbox 160 × 20 300 × 20
Exit button 80 × 30 100 × 30

Those dimensions are set to match the scroll bar width (and in turns making those texts look left-aligned).

Does it resolve any reported issue?
Not reported. Some translations get chopped off/wrapped in the Volume Change dialog. See below for examples.

Does this relate to a goal in the roadmap?
Yes, this PR tries to create a better UI/UX.

To do

This PR is Ready for Review.

How to test

  1. Set Minetest language to other languages with long string/text for sound volume.
  2. Start/restart Minetest to apply the language setting.
  3. Play in a world/server.
  4. Open the Pause menu (Esc key).
  5. Open the Volume Change dialog (click the Sound Volume button).
  6. Read the text. Make sure that the text is not chopped/wrapped.

Test results

Lang. Before After
es es before es after
fi fi before fi after
fil fil before fil after
ru ru before ru after

@srifqi srifqi merged commit aa912e9 into minetest:master Nov 15, 2023
13 checks passed
@srifqi srifqi deleted the wider_text_formspec_1 branch December 1, 2023 17:00
cx384 pushed a commit to cx384/minetest that referenced this pull request Dec 9, 2023
These containers are widened to account for translations.
kawogi pushed a commit to kawogi/minetest that referenced this pull request Dec 19, 2023
These containers are widened to account for translations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants