New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no squash] Networking improvements / hardening #14217
Conversation
No functional change and no compatibility implicatons but this better matches what is documented everywhere.
it was set to 1 too, wtf?!
If one of the channels stalls for whatever reason we can't pretend the connection is fine.
I gave this PR some testing by joining several public servers. No issues found. It would be more interesting to see how well it works on a busy. Any server owner volunteers? |
FWIW. I tried locally last weekend and did not observe any problems. This is of course a limited sample. |
This has been running on CTF for a week+ now (using the commits before cb5ac4d). Will this cause/get put in a patch release when merged? |
Unlikely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks clean and is reliable based on the server testing results. 👍
Given that this was already used in the wild: Yes, please. Unless you're really going to fast track 5.9.0 Also, if my server can help test stuff, please ping me. |
key points:
To do
This PR is Ready for Review.
It's best to review the commits individually.
How to test
I verified all the specialized stuff by hand. What this needs is real-world testing to catch oversights.