Require client to consistently use peer ID

minetest · Jan 6, 2024 · bad960a · bad960a
1 parent 930dcbf
commit bad960a
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/network/connectionthreads.cpp b/src/network/connectionthreads.cpp
@@ -1018,6 +1018,13 @@ void ConnectionReceiveThread::receive(SharedBuffer<u8> &packetdata,
 			peer->SetFullyOpen();
 			// Setup phase has a fixed timeout
 			peer->ResetTimeout();
+		} else if (!peer->isHalfOpen()) {
+			// If the peer talks to us without a peer ID when it has done so
+			// before something is definitely fishy.
+			LOG(derr_con << m_connection->getDesc()
+				<< " Peer " << peer_id << " sending without peer id?!"
+				" Ignoring." << std::endl);
+			return;
 		}
 
 		auto *udpPeer = dynamic_cast<UDPPeer *>(&peer);