Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no sq] Use newer IrrlichtMt #14405

Merged
merged 2 commits into from Feb 26, 2024
Merged

[no sq] Use newer IrrlichtMt #14405

merged 2 commits into from Feb 26, 2024

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Feb 23, 2024

note: this should be the last tagged irrlichtmt version before we merge it into our source tree.

note 2: android deps already updated so the CI build is indicative.

note 3: I have no idea why clang-tidy suddenly started complaining about double promotion but I fixed them.

note 4: should probably merge #14382 first (NDK update)

@sfan5 sfan5 added @ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements labels Feb 23, 2024
@sfan5 sfan5 changed the title Use newer IrrlichtMt [no sq] Use newer IrrlichtMt Feb 23, 2024
@sfan5 sfan5 mentioned this pull request Feb 23, 2024
@lhofhansl
Copy link
Contributor

Tried, works. Changes look good.

@sfan5 sfan5 merged commit 9fcd7f2 into minetest:master Feb 26, 2024
15 checks passed
@sfan5 sfan5 deleted the irr15 branch February 26, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants