Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no squash] Android stuff #14382

Merged
merged 4 commits into from
Mar 9, 2024
Merged

[no squash] Android stuff #14382

merged 4 commits into from
Mar 9, 2024

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Feb 18, 2024

No description provided.

@sfan5 sfan5 added @ Build CMake, build scripts, official builds, compiler and linker errors @ Documentation Android labels Feb 18, 2024
@SmallJoker
Copy link
Member

What should be tested here? Whether the build process still works? Whether the app start up?

@sfan5
Copy link
Member Author

sfan5 commented Feb 24, 2024

Both, I suppose. The CI already tells you the former.

@rubenwardy
Copy link
Member

rubenwardy commented Feb 24, 2024

I'm confident with all the commits except for Skip Android deps download if they already exist.

I don't know gradle tasks that well, so I don't know if programmatically changing the number of registered tasks would have side effects. How confident are you with this? It's possible it would mess with the task dependency graph. Googling finds the following promising looking things:

  • Task.onlyIf - only run a task if a condition is met
  • outputs.file/dir - maybe this allows you to tell gradle about the files, so it doesn't rerun the task if they exist?

@sfan5
Copy link
Member Author

sfan5 commented Feb 24, 2024

I have tested it and it works so I'd rather not rewrite it around onlyIf. AFAIK gradle also revaluates all build files & the dependency graph every time you run it so that shouldn't be an issue in practice.

@sfan5 sfan5 requested a review from rubenwardy March 6, 2024 12:30
Copy link
Member

@rubenwardy rubenwardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to break Gradle and couldn't so looks good to me

@sfan5 sfan5 merged commit f596c36 into minetest:master Mar 9, 2024
1 check passed
@sfan5 sfan5 deleted the androidbla branch March 9, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android @ Build CMake, build scripts, official builds, compiler and linker errors @ Documentation One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants