-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no squash] Android stuff #14382
[no squash] Android stuff #14382
Conversation
It's close to impossible to test locally built changes otherwise.
What should be tested here? Whether the build process still works? Whether the app start up? |
Both, I suppose. The CI already tells you the former. |
I'm confident with all the commits except for Skip Android deps download if they already exist. I don't know gradle tasks that well, so I don't know if programmatically changing the number of registered tasks would have side effects. How confident are you with this? It's possible it would mess with the task dependency graph. Googling finds the following promising looking things:
|
I have tested it and it works so I'd rather not rewrite it around |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to break Gradle and couldn't so looks good to me
No description provided.