Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosshair not visible in latest master 2d8e4df #14520

Closed
superfloh247 opened this issue Apr 5, 2024 · 6 comments · Fixed by #14521
Closed

Crosshair not visible in latest master 2d8e4df #14520

superfloh247 opened this issue Apr 5, 2024 · 6 comments · Fixed by #14521
Labels
Bug Issues that were confirmed to be a bug @ Client rendering Regression Something that used to work no longer does.

Comments

@superfloh247
Copy link
Contributor

Minetest version

Minetest 5.9.0-dev-2d8e4df (OSX)
Using LuaJIT 2.1.1710088188
Built by Clang 15.0
Running on Darwin/23.3.0 arm64
BUILD_TYPE=RelWithDebInfo
RUN_IN_PLACE=0
USE_CURL=1
USE_GETTEXT=1
USE_SOUND=1

Irrlicht device

OSX

Operating system and version

MacOS 14.3.1

CPU model

apple silicon m1pro arm64

GPU model

apple silicon m1pro arm64

Active renderer

OpenGL 2.1

Summary

Crosshair is no longer visible since a few commits - HUD is visible

affected Minetest 5.9.0-dev-2d8e4df (OSX)

screenshot_20240405_164850

not affected:
Minetest 5.8.0 (OSX)
Using Irrlicht 1.9.0mt13
Using LuaJIT 2.1.1700008891
BUILD_TYPE=Release
RUN_IN_PLACE=0
USE_CURL=1
USE_GETTEXT=1
USE_SOUND=1

screenshot_20240405_164907

Steps to reproduce

start minetest

@superfloh247 superfloh247 added the Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible label Apr 5, 2024
@superfloh247
Copy link
Contributor Author

maybe related to #14501

@grorp
Copy link
Member

grorp commented Apr 5, 2024

Oh no, the crosshair size is probably being std::floor'ed to zero. Should be an easy fix.

@superfloh247
Copy link
Contributor Author

hud_scaling = 2
makes the HUD quite ugly, and the crosshair is visible again

hud_scaling = 1
this is the usual HUD look, crosshair invisible

@superfloh247
Copy link
Contributor Author

hud_scaling = 1.51

this is a workaround which makes the HUD acceptable and the crosshair visible

@sfan5 sfan5 added the Regression Something that used to work no longer does. label Apr 5, 2024
@grorp
Copy link
Member

grorp commented Apr 5, 2024

Does grorp@79ad421 work as expected?

@superfloh247
Copy link
Contributor Author

superfloh247 commented Apr 5, 2024

yes, looks good with hud_scaling = 1 and hud_scaling not set at all

@grorp grorp added Bug Issues that were confirmed to be a bug @ Client rendering and removed Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues that were confirmed to be a bug @ Client rendering Regression Something that used to work no longer does.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants