Limit crosshair scaling to integer multiples to avoid distortion #14501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For related discussion, see #13772, https://irc.minetest.net/minetest-dev/2023-09-11 (be warned) and https://forum.minetest.net/viewtopic.php?t=30025.
This obviously isn't optimal. It's definitely better than what we had in 5.7.0. For some users it'll be better than in 5.8.0, for some users it'll be worse than in 5.8.0.
For easier testing, this PR also allows changing HUD scaling via
/setin singleplayer.To do
This PR is a Ready for Review.
How to test
Get yourself an image crosshair, for example this one by Linuxdirk: https://forum.minetest.net/download/file.php?id=28632
Set different values for
hud_scaling. See that the crosshair scales without being distorted.