Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsystem maintainers #1710

Closed
kahrl opened this issue Oct 2, 2014 · 13 comments
Closed

Subsystem maintainers #1710

kahrl opened this issue Oct 2, 2014 · 13 comments

Comments

@kahrl
Copy link
Contributor

kahrl commented Oct 2, 2014

This is mainly addressed to core devs.

Since RBA does not want to do it, I will write this issue:

  1. Since @celeron55 doesn't do minetest development these days and client/audiovisuals has by far the most open issues, I think someone else should be the client/audiovisuals subsystem maintainer. Do you agree? Who do you think it should be?
  2. What about the "maintainer conflicts" meta-subsystem?
  3. Since proller is not developing minetest anymore someone else should be the masterserver maintainer.
  4. Any takers for Build or Translation?
@kahrl
Copy link
Contributor Author

kahrl commented Oct 2, 2014

My views:

  1. Personally I would be okay with @RealBadAngel taking that role, as long as he still asks the dev channel before making potentially controversial changes. (Such things should still be pull requests and open for at least a week so people can try it)
  2. Since this role hasn't ever been used (as far as I'm aware) and c55 can always be pinged in such a case, I think it can stay the way it is.
  3. If either @sfan5 or @ShadowNinja wants to do this, I would agree with that.
  4. I could do Translation if absolutely no one else wants to do it, but I know very few languages and the weblate server will most likely be hosted by someone else.

@Zeno-
Copy link
Contributor

Zeno- commented Oct 2, 2014

I'd support RBA

@kilbith
Copy link
Contributor

kilbith commented Oct 2, 2014

I'm not a dev, but I'd support RBA too.

@Amaz1
Copy link
Contributor

Amaz1 commented Oct 2, 2014

I also support RBA. (But I'm not a dev.)

@celeron55
Copy link
Member

I can give away client/audiovisuals, but won't accept RBA to dictate it by himself. Kahrl's suggestion is fine.

@sfan5
Copy link
Member

sfan5 commented Oct 2, 2014

I'm fine with being masterserver subsystem maintainer.

@PilzAdam
Copy link
Contributor

PilzAdam commented Oct 2, 2014

I am a little bit concerned with RBA being in that role. His changes tend to break stuff, which isn't that bad, but it's rather hard to convince him to fix them (see #1705 for example; we had a long discussion about this on IRC and I'm still not sure if he is convinced that the old behavior should be restored).
On the other hand, he says that his fixes were blocked by nobody paying attention to them, so maybe it would help to have as the maintainer for that section.
I don't know...

@ShadowNinja
Copy link
Member

  1. I think that RealBadAngel is best qualified for this since he's made most of the audio/visual changes recently and knows the related code best.
  2. celeron55 can keep this role.
  3. I'll take this subsystem, although I'm fine with sfan5 taking it if he wants it.
  4. I don't know who would be best for either of these.

@paramat
Copy link
Contributor

paramat commented Oct 2, 2014

RBA does good work in making visual code more efficient, i hope he continues to contribute to Minetest, i have been looking forward to hardware lighting and use of irrlicht particles.
However, i feel that his audiovisual style (eye candy, photorealism, mainstream trendiness and lots of music) differs too much from the inherent character of Minetest (simplicity, abstraction, disregard of mainstream trends, and a refreshing lack of music), this is why he is ideal as our shader coder, but since he started work on non-shader visuals there have been too many radical and unsuitable visual changes rushed through.
From following IRC logs i can see RBA and Celeron are polar opposites in audiovisual taste, i feel Minetest needs a consistent audiovisual style that continues it's character, so the AV manager should have a Celeron-like AV taste. Ideally i would like to see Celeron continue as AV manager to ensure the character of Minetest is maintained. I feel RBA needs someone to restrain him a little ;)

@ShadowNinja
Copy link
Member

I'd personally like to see many advanced visual effects added to Minetest, with settings for them. That way Minetest can look good for everyone and still be as fast as possible.

@RealBadAngel
Copy link
Contributor

I can work with some1 with an opposite taste but only when hes here.
Working with pure virtual coder is impossible.

@nerzhul
Copy link
Member

nerzhul commented Mar 25, 2015

@kahrl @ShadowNinja does this issue needs to be opened ?

@paramat
Copy link
Contributor

paramat commented Mar 28, 2016

Subsystem maintainer system is not used anymore.

@paramat paramat closed this as completed Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests