Tweak third person eye location

[Zeno-]

No description provided.

[donat-b]

👍 Way better now.

[Megaf]

Screenshot?

[donat-b]

[Zeno-]

Edit: Oops, donat-b beat me to it

[Megaf]

It looks much better, now it' s usable.
I like it.

[SmallJoker]

Looks good.
But, why is it left-sided?

[Zeno-]

@SmallJoker because the wield item is at the right

[Calinou]

Shoulder camera can be a problem sometimes, eg. in tight spaces.

Also, generally, the camera would be at the right. It works like that in most third person shooters.

[Zeno-]

@Calinou I didn't see your PR before I did this (sorry)

Ok I'll move it to the right if that's the what is more common. I did notice the issue in tight spaces but the camera immediately behind seemed to have the same (similar) issue so I didn't dwell on it for too long.

[hoodedice]

Hmm, I think it is better to put this as an option... maybe a fourth F7 view-mode?

[BlockMen]

I prefer the current style (wow, suprise).

We already have the option to use different camera position and i have seen no server yet using it.
Now the interesting question is: Do ppl not know about it, is it to hard for most to change or is it not wanted?

[hoodedice]

"Now the interesting question is: Do ppl not know about it, is it to hard for most to change or is it not wanted?"

I actually did mess around with it, and did put the results on IRC, but people weren't so interested in it. Surprising, considering the fact that it is just one line of code to add/edit.

[Zeno-]

@BlockMen what would happen if the player wanted to play on a server but still change the eye position?

Perhaps a better solution than this current one of mine would be to add the eye position option as an option for the client (in minetest.conf) rather than it having to be modified by a server-side mod using Lua and set_eye_offset. If that solution is preferable (and I think that it probably would be) then I am happy to close this PR.

[Zeno-]

Closed/revoked for now

[BlockMen]

@Zeno- Then make sure it only applies when its nod set/modified by mods already. Else you would break that feature.

[Zeno-]

@BlockMen for sure. It needs more thought and input which is why I closed before waiting for your reply

Edit: In channel I said you were right and perhaps some kind of hybrid approach would be better