Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wield item is always fully bright #1860

Closed
Calinou opened this issue Nov 21, 2014 · 5 comments
Closed

Wield item is always fully bright #1860

Calinou opened this issue Nov 21, 2014 · 5 comments
Labels
Bug Issues that were confirmed to be a bug @ Client / Audiovisuals

Comments

@Calinou
Copy link
Member

Calinou commented Nov 21, 2014

This is only with shaders enabled. With shaders disabled, it works fine.

  1. Walk or fly into a dark area.
  2. Look at your wield item (happens with any, even an empty hand)
  3. The wield item is fully bright, even though it should be dark.
@Megaf
Copy link
Contributor

Megaf commented Nov 21, 2014

Confirmed.
screenshot_3542358366

@ShadowNinja ShadowNinja added @ Client / Audiovisuals Bug Issues that were confirmed to be a bug labels Nov 21, 2014
@sfan5 sfan5 added the Blocker The issue needs to be addressed before the next release. label Nov 22, 2014
@kahrl
Copy link
Contributor

kahrl commented Nov 26, 2014

This is caused by the shaders not supporting hardware lights, while WieldMeshSceneNode expects them to work. (Note that the problem goes away if you disable shaders.)

@kahrl kahrl added this to the 0.4.11 milestone Dec 6, 2014
@kwolekr
Copy link
Contributor

kwolekr commented Dec 23, 2014

249749d
Temporary workaround so we can release 0.4.11

@kwolekr kwolekr added Temporary workaround added and removed Blocker The issue needs to be addressed before the next release. labels Dec 23, 2014
@nerzhul nerzhul modified the milestones: 0.5, 0.4.12 Feb 18, 2015
@Calinou
Copy link
Member Author

Calinou commented Mar 22, 2015

This appears to be fixed, maybe this should be closed.

@Megaf
Copy link
Contributor

Megaf commented Mar 23, 2015

It is fixed indeed. Can be closed.

@Calinou Calinou closed this as completed Jul 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues that were confirmed to be a bug @ Client / Audiovisuals
Projects
None yet
Development

No branches or pull requests

7 participants