Lava/drowing damage is calculated on client-side only

[neoascetic]

Is this OK? I mean, I can simply recompile client without corresponding code and have no damage on any server.

[SmallJoker]

When I am on a laggy server, it mostly takes a while until the bubbles appear, so I think those things are controlled by the server.

[neoascetic]

Nope, I saw the code. There is no damage handling in ServerEnvironment::step.

[ShadowNinja]

Damage (other than punching damage) is all client-side. A server-side implementation would have issues with lag. A combined version that gives clients a little time to apply damage before applying it on the server might work.

[neoascetic]

I also think these damage types should be applied to all entities with fleshy armor group, otherwise every mobs mod developer must handle this stuff by its own.

[nerzhul]

@ShadowNinja is not the problem, this handling permit to client to bypass every damage wit ha special crafted client on PVP servers and damage_enabled servers.
This will be fixed by the 0.5. Having a client side breath/damage is unacceptable.

[neoascetic]

However, about fleshy armor group, there may be octopuses or fishes which, obviously, must not drown.

[bdjnk]

While I agree that client side breathing and damage are no good, I don't accept that this should result in any additional user noticeable lag. What is needed is proper client-side prediction (here is an excellent technical overview). This is actually generally applicable, as requested here #1072

[nerzhul]

This is fixed in the 0.4.16 i did it.

[nerzhul]

Fixed by #4981

[neoascetic]

Finally, thanks!