Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap lines longer than 80 characters in lua_api.txt #2377

Closed
wants to merge 1 commit into from
Closed

Wrap lines longer than 80 characters in lua_api.txt #2377

wants to merge 1 commit into from

Conversation

rubenwardy
Copy link
Member

...and minor formating changes

Based on #1306

ShadowNinja
ShadowNinja reviewed Feb 22, 2015
View reviewed changes
doc/lua_api.txt
{x=189, y=198}, -- < dig animation key frames
{x=200, y=219}, -- < walk+dig animation key frames
frame_speed=30): -- < animation frame speed
^
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function name removed, also ^ added.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't removed, moved to code snippet. I'm not sure about this, but this PR is just a rebase of Hoodedice's plus a few line breaks by me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function name and params should be on the first line, having an example below doesn't replace that.

Still has a superfluous ^.

@ShadowNinja ShadowNinja added enhancement @ Documentation Improvements or additions to documentation Low priority labels Feb 22, 2015
@paramat
Copy link
Contributor

paramat commented Feb 25, 2015

Looks good apart from:
Line 2581 needs more indentation.
Lines 2428 to 2435:
I agree with ShadowNinja that the function and params should be on the first line, you could perhaps then have the 'set animation for player model in third person view' line after the example. Or, have the function and params as one line, then 'set animation for player model in third person view', then the example.
The empty lines at 2429 and 2435 are out of character for the file and should be removed, along with that unnecessary '^'.

Please could this pull be updated and merged ASAP as many people need to change this file often.

@rubenwardy
Copy link
Member Author

Fixed.

@paramat
Copy link
Contributor

paramat commented Feb 25, 2015

Looks fine to me for merge.

@Zeno-
Copy link
Contributor

Zeno- commented Feb 27, 2015

commit 2b189d4

@Zeno- Zeno- closed this Feb 27, 2015
@rubenwardy rubenwardy deleted the lua_api_break branch February 27, 2015 08:36
@nerzhul nerzhul mentioned this pull request Mar 5, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@ Documentation Improvements or additions to documentation Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rubenwardy @paramat @Zeno- @ShadowNinja