wip irrlicht particles 2

[obneq]

next attempt here, using custome scene node:
https://github.com/obneq/minetest/tree/scenenodeparticles

sorry for closing and reopening instead of updating PR. this is attempt 2 at a naive replacement of mt particles with irrlicht ones.
it does not yet look like current mt particles and is not meant for straight merge. Instead, developers please review and give your feedback! Please note that this is very much WIP. Ignore style and minor issues if you can and instead let me know what could be done better differently in a larger sense.

[C1ffisme]

What advantages does it pose? Does it make them faster/better?

[kwolekr]

Both faster and better. This is using the builtin Irrlicht particle functionality which we've been waiting for :)

[nerzhul]

The original pr has collision bugs and generate some lag on Intel GPU

[nerzhul]

Then i follow it with attention :)

[Zeno-]

I'm not sure how I missed this PR. Watching.

[Zeno-]

Please don't compare floating point numbers to an absolute number

[kilbith]

So I tested that PR with your latest commit (4470c27) and here's my report :

1. Compiler's warnings

/home/jp/git/irrlicht-particles/minetest/src/particles.cpp: In member function ‘virtual const vector3df& FixNumEmitter::getDirection() const’:
/home/jp/git/irrlicht-particles/minetest/src/particles.cpp:108:87: warning: returning reference to temporary [-Wreturn-local-addr]
         virtual const core::vector3df& getDirection() const { return v3f(0.0, 0.0, 0.0); }
                                                                                       ^
/home/jp/git/irrlicht-particles/minetest/src/particles.cpp: In member function ‘virtual const irr::video::SColor& FixNumEmitter::getMinStartColor() const’:
/home/jp/git/irrlicht-particles/minetest/src/particles.cpp:111:87: warning: returning reference to temporary [-Wreturn-local-addr]
         virtual const video::SColor& getMinStartColor() const { return video::SColor(1); }
                                                                                       ^
/home/jp/git/irrlicht-particles/minetest/src/particles.cpp: In member function ‘virtual const irr::video::SColor& FixNumEmitter::getMaxStartColor() const’:
/home/jp/git/irrlicht-particles/minetest/src/particles.cpp:112:87: warning: returning reference to temporary [-Wreturn-local-addr]
         virtual const video::SColor& getMaxStartColor() const { return video::SColor(1);; }
                                                                                       ^
/home/jp/git/irrlicht-particles/minetest/src/particles.cpp: In member function ‘virtual const dimension2df& FixNumEmitter::getMaxStartSize() const’:
/home/jp/git/irrlicht-particles/minetest/src/particles.cpp:113:107: warning: returning reference to temporary [-Wreturn-local-addr]
         virtual const core::dimension2df& getMaxStartSize() const { return core::dimension2d<f32>(0.2, 0.2); }
                                                                                                           ^
/home/jp/git/irrlicht-particles/minetest/src/particles.cpp: In member function ‘virtual const dimension2df& FixNumEmitter::getMinStartSize() const’:
/home/jp/git/irrlicht-particles/minetest/src/particles.cpp:114:107: warning: returning reference to temporary [-Wreturn-local-addr]
         virtual const core::dimension2df& getMinStartSize() const { return core::dimension2d<f32>(0.2, 0.2); }
                                                                                                           ^
/home/jp/git/irrlicht-particles/minetest/src/particles.cpp: In member function ‘virtual const vector3df& FixNumEmitter::getCenter() const’:
/home/jp/git/irrlicht-particles/minetest/src/particles.cpp:115:84: warning: returning reference to temporary [-Wreturn-local-addr]
         virtual const core::vector3df& getCenter() const { return v3f(0.0, 0.0, 0.0); }
                                                                                    ^

2. In-game comparison

Particles on current master (5a1975a) - they have the good direction.

Same configuration with your Irrlicht particles branch - particles are spreading randomly everywhere surrounded by a moving white box - performances seems similar to current master.

[Zeno-]

Yes, well. Those warnings cannot be disregarded at all.

[paramat]

@obneq perhaps someone could adopt this work and continue it? Or are you planning to restart work? MT particles really need improvement.

[nerzhul]

Definitively need huge rework, possible close label