Fix bugs in mainmenu #2855
Closed
Fix bugs in mainmenu #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 all the issues I mentioned have been fixed. |
| if enable_damage then | ||
| core.setting_set("enable_damage", enable_damage) | ||
| else | ||
| menu_worldmt(selected, "enable_damage", core.setting_get("enable_damage")) |
|
Except the code which could be factorized, it's okay for me |
|
@nerzhul Done. Better ? |
|
@kilbith yes ! thanks |
|
👍 you merge if you +1ed nrz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last attempt to fix this annoying issue : #2548
With suggestions of @rubenwardy and @ShadowNinja applied.