Little optimization on getAdded/Removed activeobjects per player loop. #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use std::queue instead of std::set, we don't need a so heavy container. Don't convert position to int to convert it to float in the next function
nerzhul
added
@ Server / Client / Env.
Maintenance
|
@est31 if you get time to review this easy PR (some lines because of coding style) |
| infostream<<"ServerEnvironment::getRemovedActiveObjects():" | ||
| <<" object in current_objects is NULL"<<std::endl; | ||
| removed_objects.insert(id); | ||
| if(object == NULL) { |
|
This is something for after the freeze. |
|
Oh i was a little bit tired when fixing coding style, doing it soon |
|
@nerzhul do you have time now? |
|
Did the changes myself :-) 9c635f2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use std::queue instead of std::set, we don't need a so heavy container.
Don't convert position to int to convert it to float in the next function