Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android APK builder includes too many files #3431

Closed
ShadowNinja opened this issue Dec 7, 2015 · 10 comments
Closed

Android APK builder includes too many files #3431

ShadowNinja opened this issue Dec 7, 2015 · 10 comments
Labels

Comments

@ShadowNinja
Copy link
Member

Recently, it tried to add all of doc/, including doc/html/ which is over 300MiB! (I ended up just deleting the folder and regenerating it later because excluding it ended up being harder than I thought)
However, doc/ shouldn't really be included at all, since it's only accessible by browsing the "SD card" or unpacking the app.
I suspect there are other unnecessary files included, but I haven't done a thorough check.

@est31
Copy link
Contributor

est31 commented Dec 7, 2015

The license is in doc/, and we should ship with the license.
But yeah, we probably shouldn't put the doxygen docs inside.

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 7, 2015

Anyone who needs to can open and read the license github.
Just do not need locale and media folders

@sapier
Copy link
Contributor

sapier commented Dec 15, 2015

#3454 clears any html folder that might end up in apk

@sapier
Copy link
Contributor

sapier commented Dec 17, 2015

fixed by dcb91cf

@sapier sapier closed this as completed Dec 17, 2015
@ShadowNinja ShadowNinja reopened this Dec 18, 2015
@ShadowNinja
Copy link
Member Author

Said patch still copies the directory and deletes it afterwards, which means that it wastes a bunch of time and temporarily uses a lot of disk space. Also, doc/html isn't the only item that shouldn't be included, in fact the only thing from doc/ that should be included is maybe lgpl-2.1.txt. Also, client/serverlist probably shouldn't be included either.

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 18, 2015

LGPL does require the inclusion of the contents of the file in the APK? Technically, there is no explanation anywhere that you can find the file in a specific folder on your system. Hence, it is necessary to create a separate tab in the game with a license, if necessary. Many users are stupid, they will not be looking for something in the file system.

@sapier sapier added the Won't fix The bug report was rejected (confirmed or not) and will not be fixed. label Dec 19, 2015
@sapier
Copy link
Contributor

sapier commented Dec 19, 2015

this is picky I'm quite sure we've got worse problems then some memory on build machine used for a couple of seconds.
Feel free to fix it yourself if you believe it to be worth your time ;-)

@ShadowNinja
Copy link
Member Author

#3471

@est31 est31 removed the Won't fix The bug report was rejected (confirmed or not) and will not be fixed. label Dec 19, 2015
@est31
Copy link
Contributor

est31 commented Dec 19, 2015

3471 would fix it.

@sapier
Copy link
Contributor

sapier commented Dec 20, 2015

fixed by b4eb614

@sapier sapier closed this as completed Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants