-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android APK builder includes too many files #3431
Comments
The license is in |
Anyone who needs to can open and read the license github. |
#3454 clears any html folder that might end up in apk |
fixed by dcb91cf |
Said patch still copies the directory and deletes it afterwards, which means that it wastes a bunch of time and temporarily uses a lot of disk space. Also, |
LGPL does require the inclusion of the contents of the file in the APK? Technically, there is no explanation anywhere that you can find the file in a specific folder on your system. Hence, it is necessary to create a separate tab in the game with a license, if necessary. Many users are stupid, they will not be looking for something in the file system. |
this is picky I'm quite sure we've got worse problems then some memory on build machine used for a couple of seconds. |
3471 would fix it. |
fixed by b4eb614 |
Recently, it tried to add all of
doc/
, includingdoc/html/
which is over 300MiB! (I ended up just deleting the folder and regenerating it later because excluding it ended up being harder than I thought)However,
doc/
shouldn't really be included at all, since it's only accessible by browsing the "SD card" or unpacking the app.I suspect there are other unnecessary files included, but I haven't done a thorough check.
The text was updated successfully, but these errors were encountered: