Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update android dependencies (openssl/curl/irrlicht) #3454

Closed
wants to merge 2 commits into from

Conversation

sapier
Copy link
Contributor

@sapier sapier commented Dec 13, 2015

Update openssl to 1.0.2e
Make openssl use gmp library
Update curl to 7.46.0
Update irrlicht to recent opengl-es branch

Recent openssl android builds don't seem to support disabling certain ciphers any longer we shoult try from time to time to disable them again

@sapier sapier changed the title Update openssl to 1.0.2e Update android dependencys (Openssl/curl/irrlicht) Dec 13, 2015
@sapier sapier changed the title Update android dependencys (Openssl/curl/irrlicht) Update android dependencys (openssl/curl/irrlicht) Dec 13, 2015
@sapier sapier added @ Client / Audiovisuals Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Android labels Dec 13, 2015
@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 13, 2015

I checked and it works fine for me. 👍

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 13, 2015

You can include this https://github.com/inetic/ogg-vorbis-for-android ?

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 13, 2015

Bugs: You disable openssl_arch.patch
I open Credits tab or write cyrillic latters on textform and all text on minetest
becomes invisible

@est31
Copy link
Contributor

est31 commented Dec 14, 2015

This will fix #3366 then.

@sapier
Copy link
Contributor Author

sapier commented Dec 14, 2015

You're right about the arch patch, I thought it's not necessary any longer but didn't look carefull enough. It still might b relevant for mips and old arm which aren't default. I'll update that patch too.

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 14, 2015

The last 3 years did not come out, no phone or tablet on MIPS. On armv6 in Minetest you get FPS 3-4. This is how to put Windows 10 on 512 RAM. This will work, but no one will never use it.

@sapier
Copy link
Contributor Author

sapier commented Dec 14, 2015

https://github.com/inetic/ogg-vorbis-for-android is about 3 years old. If I remember correct I did try to use that code on initial integration but it didn't work.

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 14, 2015

@sapier , you can change version ogg and vorbis libs on this file https://github.com/inetic/ogg-vorbis-for-android/blob/master/build.sh

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 14, 2015

I think you need to put Labels WIP or No merge, as now Irrlicht is not yet fully completed. The problem I described above.

@sapier
Copy link
Contributor Author

sapier commented Dec 14, 2015

Could you provide at least basic information about your problem prior calling it a blocker?
Basic information is:
*exact device name as well as hw version (there may be regional specifics or hw updates)
*exact version of android installed (e.g. stock android 5.0, cyanogen mod 6.0 ...)

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 14, 2015

Heh :)
Asus Zenfone 2, Android 5.1, stock.
LG G4 CyanogenMod 13 (6.0.1).
Russian locale. I open Creit tabs and all text just disappeared in the game. If you want, I can check on all versions of 4.1-5.0 on a lot of phones that will be in my office tomorrow

@sapier
Copy link
Contributor Author

sapier commented Dec 14, 2015

Monte48 that be great, not because of this bug but I could update the list of supported devices if you have successfully tested them ;-)

How do you switch to russion, "language = ru" in minetest.conf doesn't have any effect and language selection dialog is broken (way to big and positioned wrong) ... haven't tried on current release but I guess it's there too

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 14, 2015

@sapier, no-no. On my phone set russian locale. Minetest on english lang.

@sapier
Copy link
Contributor Author

sapier commented Dec 15, 2015

Monte48 that's crazy ;-) locale handling is completely messed up on android I'm astonished it does work at all ;-). My first guess is irrlicht guys did improve locale support thus getting trouble with broken android configs ... maybe we should just make sure no locales are picked up at all.
Btw locales are a huge mess on windows too ...

Edit1:
just tried to switch my phone to what I believed to be russion "Cp..." I cant read cyrillic letters. At least on cyanogen mod 12.1 on sony xperia m minetest stays english and doesn't mess up text

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 15, 2015

One note - I have to delete the folder locale! I removed a lot of things in MultiCraft :)
You could send your apk from me with your changes?
Yes, locale is driving me crazy. As well as the need for a large number of png and xml files on fonts folder, the removal of which did not change anything for me. In addition to reducing apk sized -5 MB!

@sapier
Copy link
Contributor Author

sapier commented Dec 15, 2015

true those xml and png files are only required for builds without fontconfig and android build obviously does support fontconfig. The only reason for them beeing there is because asset copy target is quite stupid. Just cleaning them prior building the apk wont do any harm to the android version.

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 15, 2015

NativeActivity crash on start

@sapier
Copy link
Contributor Author

sapier commented Dec 15, 2015

ok ok did only work because I didn't delete the old mt folder, checking once again.
Edit1:
removing png/xml files was wrong, I accidental removed ttf too

Edit2:
http://www.file-upload.net/download-11127033/Minetest-debug.apk.html

@sapier sapier changed the title Update android dependencys (openssl/curl/irrlicht) Update android dependencies (openssl/curl/irrlicht) Dec 15, 2015
@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 15, 2015

screenshot_20151216-010928

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 15, 2015

@sapier
Copy link
Contributor Author

sapier commented Dec 16, 2015

curl binary wtf? .... hmmm I can't even remember why I did add it does ANYONE know for what the binary might be usefull?
Looks like dead code ... instead of updating I'm gonna remove it ;-)

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 16, 2015

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 16, 2015

@est31
Copy link
Contributor

est31 commented Dec 16, 2015

@sapier agree binary download is best to be removed.

@sapier sapier force-pushed the update_android_libs_dec15 branch 4 times, most recently from 2bfeb57 to 6f1ca0a Compare December 17, 2015 23:45
@sapier
Copy link
Contributor Author

sapier commented Dec 17, 2015

Split to those parts which don't cause regressions and those which do, obviously irrlicht 1.9 still has issues

@sapier
Copy link
Contributor Author

sapier commented Dec 18, 2015

well android test failing is quite obvious as gcc is updated to 4.9 which isn't honored by build env

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 18, 2015

@sapier, I build using 4.9 more than six months, no problems

@sapier
Copy link
Contributor Author

sapier commented Dec 18, 2015

Jenkins doesn't:
Invalid toolchain name: arm-linux-androideabi-4.9
Please use --toolchain= with the name of a toolchain supported by the source NDK.
Try one of: arm-linux-androideabi-4.6 arm-linux-androideabi-4.8 arm-linux-androideabi-clang3.3 arm-linux-androideabi-clang3.4 llvm-3.3 llvm-3.4 mipsel-linux-android-4.6 mipsel-linux-android-4.8 mipsel-linux-android-clang3.3 mipsel-linux-android-clang3.4 renderscript x86-4.6

@MoNTE48
Copy link
Contributor

MoNTE48 commented Dec 18, 2015

He-he, wow. Nrz very cool. How long to build jenkins? 10 min?

Sapier and others added 2 commits December 30, 2015 01:54
@nerzhul
Copy link
Member

nerzhul commented Jan 15, 2016

@MoNTE48 a little bit more i think. Maybe i should update NDK to a greater version

@MoNTE48
Copy link
Contributor

MoNTE48 commented Jan 15, 2016

@nerzhul , yes, update NDK the SDK.
Which processor you use and Hard or SSD? Thank you!

@nerzhul
Copy link
Member

nerzhul commented Jan 15, 2016

Hosting is done on a dedicated server. For ndk some things should be tested before upgrading

@MoNTE48
Copy link
Contributor

MoNTE48 commented Jan 15, 2016

@nerzhul, but ssd or hard ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android @ Client / Audiovisuals Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Rebase needed The PR needs to be rebased by its author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants