-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21-25% FPS drop with shaders disabled due to vertex tangents commit #3530
Comments
@RealBadAngel is there anything you can do to improve performance? |
i can split shaders/non shaders renderers, that would be the best way |
I think slowing down rendering by bloating up the vertex data to create overly fancy graphics is not something that belongs in Minetest. This should have been catched earlier. I am not sure what should be done to it now. |
i will code that in next few days |
Thought i had better do a third test to be more scientific. |
See #2755 and #2783. The commit tested is 2783 merged 14 June 2015.
The use of vertex tangents enables many shader effects and speeds up some current shaders, but unfortunately has an effect on FPS when shaders are disabled.
At the time VanessaE profiled the commit and found only an insignificant drop in FPS, which is why it was merged. Much later kwolekr found a 25% drop in FPS. Unfortunately my own test has shown a drop of 21-25%.
First 2 tests:
In mgv7 with view range 320 and fog disabled:
First location: FPS dropped from 38 to 30, down to 79%.
Second location: FPS dropped from 36 to 27, down to 75%.
Third test.
In mgv7 with view range 128 and fog disabled:
FPS dropped from 56 to 44, down 21% to 79%
To reproduce conditions i set a static spawn and did not move, panned around for a few minutes to let world generate out to the generate distance, then focussed on the exact same spot, same yaw value.
System details:
Intel Core i5-4670T CPU @2.30GHz x 4
Intel Haswell Desktop integrated graphics (no graphics card)
OS type 64 bit
Linux Ubuntu 14.04 LTS
The text was updated successfully, but these errors were encountered: