Update credits tab #3907
Update credits tab #3907
Conversation
est31
force-pushed
the
update_credits_tab
branch
from
caf1216
to
186ee97
Compare
|
@sofar is going to be core-dev soon. It's not his place to be in contributors between 0.4.14 and 0.4.15 (rather in the rank above). |
|
@kilbith i was in contributors too before I became core dev. Whether he becomes core dev or whether he wants to become such is a different matter. I just looked at |
|
Contributors is fine. I was asked and have told several folks that I'd like to do one release as contributor. |
|
Next time you update this, please could you change my full name to 'Matt Gregory'? i used to spell it with 1 't' but prefer 2 now. |
est31
force-pushed
the
update_credits_tab
branch
from
186ee97
to
2820ca1
Compare
|
@paramat done |
Why ? It fits the "Update credits tab" scope and the honouring is more expected from a core-dev. |
est31
force-pushed
the
update_credits_tab
branch
from
2820ca1
to
0b45514
Compare
|
Okay then, thought you wanted to provide some text. I have added a proposal, we could include the same text in polish below, @red-001 can you translate it and reply it in this PR? Then I can include it into the PR. |
| @@ -80,6 +82,11 @@ tab_credits = { | |||
| "tablecolumns[color;text]" .. | |||
| "tableoptions[background=#00000000;highlight=#00000000;border=false]" .. | |||
| "table[3.5,-0.25;8.5,5.8;list_credits;" .. | |||
| "#FFFF00," .. fgettext("Dedication of the current release") .. ",," .. | |||
| "The " .. core.get_version() .. " release is dedicated to the memory of" .. ",," .. | |||
There was a problem hiding this comment.
The version getter is unnecessary since only 0.4.14 is dedicated to RBA.
|
English-only is fine so that everyone understand it. |
est31
force-pushed
the
update_credits_tab
branch
from
0b45514
to
9a5c230
Compare
|
its just an idea to have it bilingual |
est31
force-pushed
the
update_credits_tab
branch
from
9a5c230
to
f573a7e
Compare
| "#FFFF00," .. "Dedication of the current release" .. ",," .. | ||
| "The 0.4.14 release is dedicated to the memory of" .. ",," .. | ||
| "Minetest developer Maciej Kasatkin (RealBadAngel)" .. ",," .. | ||
| "who died on March 23 2016." .. ",," .. |
There was a problem hiding this comment.
Thanks for spotting, it indeed is march 24.
est31
force-pushed
the
update_credits_tab
branch
from
f573a7e
to
4fc52e6
Compare
| "Maciej Kasatkin (RealBadAngel) <maciej.kasatkin@o2.pl>", | ||
| "Lisa Milne (darkrose) <lisa@ltmnet.com>", | ||
| "proller", | ||
| "Craig Robbins (Zeno)", |
There was a problem hiding this comment.
Zeno actually quit? Or is he currently inactive?
There was a problem hiding this comment.
|
gregorycu is actively contributing, and he could be made a core developer soon as well, FWIW. |
|
@Zeno- decided to come back : http://irc.minetest.ru/minetest-dev/2016-04-01#i_4571466 |
est31
force-pushed
the
update_credits_tab
branch
from
4fc52e6
to
4c2d749
Compare
est31
force-pushed
the
update_credits_tab
branch
from
4c2d749
to
d0e9492
Compare
est31
force-pushed
the
update_credits_tab
branch
from
d0e9492
to
32fb05a
Compare
BlockMenandZenoto the previous core devs section@duane-r @sofar I have added you to the list of contributors, do you want to change something about your appearance?
This PR should be merged shortly before the release so that we can update it if some new contributors get added.