Add basic_privs setting #3977
Closed
Add basic_privs setting #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenwardy
force-pushed
the
basic_privs_2
branch
from
ba2b7dc
to
1abf005
Compare
|
👍 I like this better than #3976 |
|
Much simpler, too. Is it worth documenting in lua_api.txt? |
|
You mean fixing the docs? Yes, you can do it. |
rubenwardy
force-pushed
the
basic_privs_2
branch
from
1abf005
to
566be1a
Compare
|
Ahh yes, this is nice! |
|
👍 This doesn't belong into |
|
Ah well, its okay if its not documented in lua_api.txt too. Sorry I was mistaken and believed that the table case wasn't documented at all. |
|
I added a note there as that's one of the places I'd look before bothering to go into builtin/. |
|
@rubenwardy the problem is that it's not part of the API. What if the setting changes in the future? |
|
Will merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.