You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Minetest may screw up the list of mod dependencies in the main menu if the line endings of depends.txt are in “Windows” mode and Minetest runs on Linux (my system):
The text seems to be a “half line” too high. The file was stored with “Windows” line endings. If I convert depends.txt to “UNIX” mode, Minetest shows it correctly:
The source depends.txt file used for this example:
My guess:
So the bug here seems to be that Minetest expects depends.txt to have “UNIX”-style line endings because I am on Linux. Ideally, Minetest should be able to deal with all 3 possible line ending types (Windows, UNIX, Mac) correctly on any system.
The text was updated successfully, but these errors were encountered:
This fixes a bug existing in modmgr.lua as reported by @Wuzzy2 which
caused the mod dependency list to glitch if input was using a line
terminator different than the OS default.
The C++ code does not need any changes as it already trims CR
occurrences on platforms on which the line termination sequence is LF.
Taken into account the size of the depends.txt files used, this should
not introduce a noticeable performance regression.
Fixesminetest#4720
Minetest may screw up the list of mod dependencies in the main menu if the line endings of
depends.txt
are in “Windows” mode and Minetest runs on Linux (my system):The text seems to be a “half line” too high. The file was stored with “Windows” line endings. If I convert
depends.txt
to “UNIX” mode, Minetest shows it correctly:The source
depends.txt
file used for this example:(No line-break at the final line, but it makes no difference.)
Tested in 70e2df4.
My guess:
So the bug here seems to be that Minetest expects
depends.txt
to have “UNIX”-style line endings because I am on Linux. Ideally, Minetest should be able to deal with all 3 possible line ending types (Windows, UNIX, Mac) correctly on any system.The text was updated successfully, but these errors were encountered: