Small fix for colorwallmounted and colorfacedir nodes #5271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains: correct node placement prediction for attached wallmounted colored nodes, correct placement direction for colorfacedir and colorwallmounted nodes and correct deatch mechanism for attached colored wallmounted nodes
paramat
reviewed
Feb 18, 2017
| @@ -134,7 +134,8 @@ end | |||
| function builtin_shared.check_attached_node(p, n) | |||
| local def = core.registered_nodes[n.name] | |||
| local d = {x = 0, y = 0, z = 0} | |||
| if def.paramtype2 == "wallmounted" then | |||
| if def.paramtype2 == "wallmounted" or | |||
| def.paramtype2 == "colorwallmounted" then | |||
| -- The fallback vector here is in case 'wallmounted to dir' is nil due | |||
| -- to voxelmanip placing a wallmounted node without resetting a | |||
| -- pre-existing param2 value that is out-of-range for wallmounted. | |||
There was a problem hiding this comment.
Line 143 below: need to take the first 3 bits of param2?
There was a problem hiding this comment.
No, wallmounted_to_dir does that.
|
Otherwise looks fine. |
|
👍 |
|
Sorry, accidental close. |
|
fine with me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains: