Extend is_yes()

[red-001]

This is used by Settings::getBool so it would make sense for it to return true when passed on.

for:

• rubenwardy
• nerzhul

against

• sfan5
• celeron55
• zeno ?

[rubenwardy]

👍

[sfan5]

No it would not, this pull was already rejected last time you made it (~6 weeks ago)

http://irc.minetest.net/minetest-dev/2017-01-06#i_4780321 // #5002

[red-001]

Consider that that one also had one approval that should add up to two approvals. Shouldn't it at least be reconsidered? Plus I though your issue with it was that I hasn't had gotten two approvals?

[rubenwardy]

I think this makes sense as it makes it consistent with eg: cmake

[paramat]

But is 'on' needed for something? best that settings avoid 'on' and 'off'.
If not -1.

[rubenwardy]

tbh it's not that useful in settings, more for mods and UIs. So this PR can be worked around.

tbh, it's not worth debating this - it's such a minor thing