Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various performance issues reported by cppcheck + code style (CI) #5635

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Fix various performance issues reported by cppcheck + code style (CI) #5635

merged 1 commit into from
Apr 21, 2017

Conversation

nerzhul
Copy link
Member

@nerzhul nerzhul commented Apr 21, 2017

  • Make CI happy with code style on master
  • guiFileSelectMenu: remove useless includes
  • some performance fixes pointed by cppcheck
  • remove some useless casts
  • TextDest: remove unused setFormSpec function

@nerzhul
Fix various performance issues reported by cppcheck + code style (CI)
e9150f3 
* Make CI happy with code style on master
* guiFileSelectMenu: remove useless includes
* some performance fixes pointed by cppcheck
* remove some useless casts
* TextDest: remove unused setFormSpec function
@nerzhul nerzhul added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Performance Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Apr 21, 2017
@nerzhul nerzhul merged commit dc0e909 into minetest:master Apr 21, 2017
@nerzhul nerzhul deleted the cppcheck_perffix5 branch August 19, 2017 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Performance Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nerzhul