Copy lua51.dll (luajit) to bindir #6148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
reviewed
Jul 18, 2017
src/CMakeLists.txt
Outdated
| @@ -292,6 +292,8 @@ if(WIN32) | |||
| set(VORBIS_DLL "" CACHE FILEPATH "Path to libvorbis.dll for installation (optional)") | |||
| set(VORBISFILE_DLL "" CACHE FILEPATH "Path to libvorbisfile.dll for installation (optional)") | |||
| endif() | |||
|
|
|||
| set(LUA_DLL "" CACHE FILEPATH "Path to lua51.dll for installation (optional)") | |||
There was a problem hiding this comment.
should be inside if(USE_LUAJIT)
also shouldn't the dll be named libluajit.dll or similar?
There was a problem hiding this comment.
Done.
Well, if you use a custom build script, the name may differ, but using the official build instructions, its called lua51.dll
sfan5
added
@ Build
SmallJoker
approved these changes
Jul 18, 2017
Eurybot
pushed a commit
to MT-Eurythmia/minetest
that referenced
this pull request
Jul 25, 2017
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are building with luajit, you had to manually copy the lua51.dll to the Minetest bin dir.
This PR lets CMake do it like the other dll's.