Add file and line to NodeDef field deprecation warning

[rubenwardy]

WARNING[Main]: Field dug_item: Deprecated; use 'drop' field (at ...netest/bin/../games/minetest_game/mods/default/nodes.lua:1668)

Replaces #3957

[rubenwardy]

For some reason doing this results in Minetest printing out the wrong line

function foo()
    minetest.get_mapgen_params() -- should be this line
end 

foo() -- this line is given

Edit: this is present in master too???

[sfan5]

my brain parses this as badget info
no but wouldn't <invalid>:0 suffice in as error value?

[sfan5]

there might be a case where you want the actual calling function, i propose 1 + offset

[rubenwardy]

Is there a reason your code uses 2 rather than 1 here? It prints out the wrong position as detailed above

[sfan5]

since log_deprecated is called by a wrapper function through core.log() you'll want to get the function that called the wrapper, not the wrapper itself....
okay this turns out to be trickier as log_deprecated is also called directly from C++ in some cases

[rubenwardy]

Ah, that explains it. I'll have to pass an offset into log_deprecated and default to 0, unfortunately

[rubenwardy]

So, currently it'll say that there's a deprecation in builtin/game/register.lua if you use a deprecate item def field. The only thing that can be done now is to manually crawl through the back stack to find the first element which isn't builtin

[nerzhul]

use append operator instead of + to prevent multiple memory string copy

[rubenwardy]

What should be done here? This PR fixes a crash when calling a deprecated field, however the location it gives may not be accurate.

I'm not sure how to properly pass in the path to builtin to work out where in the stack the last entry before builtin. I could instead try and find builtin in the path, but this will break if any mods or directories in mods are called builtin.

This could be merged as-is, as it's still more accurate than the current code on master and doesn't crash

[nerzhul]

use append function instead of "+"

[nerzhul]

u32