Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.4.17 bug] Fatal error in void log_deprecated() #6798

Closed
paramat opened this issue Dec 17, 2017 · 4 comments
Closed

[0.4.17 bug] Fatal error in void log_deprecated() #6798

paramat opened this issue Dec 17, 2017 · 4 comments
Labels
Blocker The issue needs to be addressed before the next release. Bug Issues that were confirmed to be a bug

Comments

@paramat
Copy link
Contributor

paramat commented Dec 17, 2017 •
edited 

2017-12-17 00:44:29: ERROR[Main]: In thread 7f8d58f33880:
2017-12-17 00:44:29: ERROR[Main]: /.../minetest/src/script/common/c_internal.cpp:9c:
void log_deprecated(lua_State*, const string&): A fatal error occured: lua_getstack() failed

When running an old mod that likely has deprecated code, when 'deprecated_lua_api_handling = log or error'.
Also reported by @sofar http://irc.minetest.net/minetest-dev/2017-12-16#i_5169873
sfan5 reports #6708 might fix it.
@paramat paramat added the Bug Issues that were confirmed to be a bug label Dec 17, 2017
@rubenwardy rubenwardy self-assigned this Dec 17, 2017
@rubenwardy
Copy link
Member

#6708

@rubenwardy rubenwardy mentioned this issue Jan 3, 2018
Closed
@rubenwardy rubenwardy added the Blocker The issue needs to be addressed before the next release. label Jun 7, 2018
@SmallJoker SmallJoker mentioned this issue Jun 7, 2018
Closed
@ghost ghost mentioned this issue Jun 7, 2018
Merged
@paramat paramat modified the milestones: 0.5.0, 0.4.17 Jun 7, 2018
@rubenwardy rubenwardy modified the milestones: 0.5.0, 0.4.17 Jun 8, 2018
@paramat
Copy link
Contributor Author

paramat commented Jun 8, 2018

See #7419 (comment)

Fixed in 0.5.0-dev a1598e1#diff-4e3f0a64f234ea624dbf1b329eb56bd9R157

If this is a duplicate of #7419 and is fixed in 0.5dev why is there a 0.5 milestone for this?
This issue is open for the bug in 0.4.17?

@paramat paramat modified the milestones: 0.5.0, 0.4.17.1 Jun 8, 2018
@rubenwardy rubenwardy removed their assignment Jun 8, 2018
@rubenwardy
Copy link
Member

This issue was made long before that commit

@paramat paramat removed this from the 0.5.0 milestone Jun 9, 2018
@paramat paramat added this to the 0.4.17.1 milestone Jun 9, 2018
@paramat paramat changed the title Fatal error in void log_deprecated() when 'deprecated_lua_api_handling = log or error' [0.4.17 bug] Fatal error in void log_deprecated() Jun 9, 2018
@SmallJoker
Copy link
Member

Fixed in 0.4.17.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker The issue needs to be addressed before the next release. Bug Issues that were confirmed to be a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SmallJoker @rubenwardy @paramat