Lighting glitch since "Variable name fix + structure creation unrolling in lighting code"

[mtango688]

Issue type

• Bug report

Minetest version

See the screenshots (bcdb3d5)

OS / Hardware

Operating system:
CPU: AMD

GPU model: nVidia 1050
OpenGL version: ?

Summary

When using commit bcdb3d5 or newer, changes to mesecon (powerred/unpowered) causes other lights nearby to lose their spread.

Steps to reproduce

Create a new world with Minetest_game and add Mesecons as a mod.
Change to night and place torches and mesecons.
Change the state of the mesecons.

[rubenwardy]

May be this line: bcdb3d5#diff-d8d3b69601fbe8b3c44441473970f0a0R1117

Try changing to

const ContentFeatures &newf = ndef->get(newnode);

[mtango688]

I don't think so. It's probably better if you can observe the bug first-hand.

[rubenwardy]

Can confirm that bcdb3d5 is the first bad commit. @nerzhul

[nOOb3167]

typo, Y instead of Z

MapNode node = block->getNodeNoCheck(relpos.X, relpos.Y, relpos.Y, &is_valid);

MapNode node = block->getNodeNoCheck(relpos.X, relpos.Y, relpos.Z, &is_valid);

seems to resolve the issue

unavoidable considering all the XYZ soup - did not notice until the 3rd readthrough.

[SmallJoker]

@nOOb3167 Thanks for your research. This issue is now fixed: ee20433

[nerzhul]

Ty @SmallJoker. It seems a missing force push didn't pass on my pr before merge, as i replaced (x,y,z) with v3s16 for that call...